feat: implement std.match as standard function#715
feat: implement std.match as standard function#715rohitjangid wants to merge 1 commit intogoogle:masterfrom
Conversation
|
I was hoping to merge google/jsonnet#1039 this release, but I don't think we have a go-jsonnet equivalent yet (@sbarzowski is that right?) Apparently the stdlib regexes in Go are similar enough that we can consider them compatible, in which case maybe all you have to do is make sure the API has the same function name / param name as the existing PR? |
|
If that is the case, I could create a separate PR with equivalent implementation of all the api in go. Let me know if I should go ahead with that considering cpp PR is yet to be merged. |
|
I didn't found any documentation for google/jsonnet#1039 |
|
Very cool that this is happening! Yeah, both this and google/jsonnet#1039 are RE2 based, so I'd just use go standard library here. There are minor differences, but full regexp compatibility beyond simple cases cannot be guaranteed anyway – they are not specified precisely enough.
it doesn't have docs (yet), but you can see the summary in the PR description. If we could have the functions as described there, it would be great. |
|
I think this is going to make a lot of users very happy |
Implement
std.matchin standard librarycpp-jsonnet PR: google/jsonnet#1100